Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rtk identity traits #5125

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: rtk identity traits #5125

wants to merge 6 commits into from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Feb 18, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Migrates identity trait crud to rtk / typescript

How did you test this code?

  • Created, deleted and updated traits from core projects as well as edge, validated that segments were adjusted

@kyle-ssg
RTK identity traits
15a6b18
@kyle-ssg
RTK identity traits
4e4bb52
@kyle-ssg
Merge branch 'refs/heads/main' into chore/rtk-identity-traits
0cf996a 
# Conflicts:
#	frontend/common/types/requests.ts
#	frontend/common/types/responses.ts
@kyle-ssg kyle-ssg requested a review from a team as a code owner February 18, 2025 14:52
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team February 18, 2025 14:52
@vercel Vercel
Copy link

vercel bot commented Feb 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 1:48pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 1:48pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 1:48pm

@kyle-ssg kyle-ssg marked this pull request as draft February 18, 2025 14:52
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard chore labels Feb 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5125 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5125 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5125 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5125 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5125 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5125 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

Uffizzi Ephemeral Environment deployment-61053

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5125

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@kyle-ssg kyle-ssg removed the request for review from tiagoapolo February 19, 2025 10:08
@kyle-ssg
Merge branch 'refs/heads/main' into chore/rtk-identity-traits
23e3be4 
# Conflicts:
#	frontend/common/types/requests.ts
#	frontend/web/components/pages/UserPage.tsx
@kyle-ssg
Identity traits
65bad13
@github-actions github-actions bot added chore and removed chore labels Feb 19, 2025
@kyle-ssg kyle-ssg requested a review from tiagoapolo February 19, 2025 13:24
@kyle-ssg kyle-ssg marked this pull request as ready for review February 19, 2025 13:25
@github-actions github-actions bot added chore and removed chore labels Feb 19, 2025
@github-actions github-actions bot added chore and removed chore labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoapolo tiagoapolo tiagoapolo approved these changes

Assignees
No one assigned
Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @tiagoapolo