Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Treat 0 padded number as string #5137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Treat 0 padded number as string #5137

wants to merge 1 commit into from

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes #4909, the frontend detects and casts numeric strings for certain requests, it didn't treat strings with leading 0s as a string.

How did you test this code?

Try to create a segment with a condition value of 0123

@kyle-ssg kyle-ssg requested a review from a team as a code owner February 19, 2025 15:29
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team February 19, 2025 15:29
@vercel Vercel
Copy link

vercel bot commented Feb 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 3:32pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 3:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 19, 2025 3:32pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5137 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5137 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5137 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5137 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5137 Finished ✅ Results ✅

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Feb 19, 2025
@kyle-ssg kyle-ssg mentioned this pull request Feb 19, 2025
Open
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited
Loading

Uffizzi Ephemeral Environment deployment-61104

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5137

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoapolo tiagoapolo tiagoapolo approved these changes

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot type leading zeroes into segment condition values
3 participants
@kyle-ssg @tiagoapolo @matthewelwell