Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default scheduled changes #5141

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tiagoapolo
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Ref: #4238

  • Converts DateSelect and ChangeRequestModal to Typescript
  • Adds validation in change/schedule changes
Screenshot 2025-02-20 at 00 04 20 Screenshot 2025-02-20 at 00 05 46

How did you test this code?

Tested all cases manually

@tiagoapolo tiagoapolo requested a review from a team as a code owner February 20, 2025 03:10
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team February 20, 2025 03:10
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 3:10am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 3:10am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 20, 2025 3:10am

@tiagoapolo tiagoapolo self-assigned this Feb 20, 2025
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Feb 20, 2025
Copy link
Contributor

github-actions bot commented Feb 20, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5141 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5141 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-5141 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-5141 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5141 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5141 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Uffizzi Ephemeral Environment deployment-61127

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5141

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@tiagoapolo tiagoapolo changed the title Fix/4238 default scheduled changes fix: default scheduled changes Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant