Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feature panel url updating url when opening #5159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Feb 25, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes:

  • opening create/edit feature panel was not updating url to match current tab
  • use effect was reopening the feature panel modal even when it was already open

How did you test this code?

Please describe.

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 3:18am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 3:18am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 25, 2025 3:18am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Feb 25, 2025
@tiagoapolo tiagoapolo self-assigned this Feb 25, 2025
@tiagoapolo tiagoapolo marked this pull request as ready for review February 25, 2025 03:20
@tiagoapolo tiagoapolo requested a review from a team as a code owner February 25, 2025 03:20
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team February 25, 2025 03:20
@github-actions github-actions bot added fix and removed fix labels Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5159 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5159 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5159 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5159 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5159 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Uffizzi Ephemeral Environment deployment-61286

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5159

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant