-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using cert manager to issue TLS certs #267
Conversation
This allows K8s to use cert-manager.io to issue TLS certs for both the core Forge apps and the Instances.
node-red:3.0.2-main-linux-amd64 scan results1 files ±0 4 suites ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2348c7d. ± Comparison against base commit 07c5394. ♻️ This comment has been updated with latest results. |
node-red:3.1.x-main-linux-amd64 scan results3 tests +3 0 ✅ ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2348c7d. ± Comparison against base commit 07c5394. ♻️ This comment has been updated with latest results. |
node-red:2.2.3-main-linux-amd64 scan results 1 files ±0 4 suites ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2348c7d. ± Comparison against base commit 07c5394. This pull request removes 11 and adds 16 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
node-red:3.0.2-main-linux-arm64 scan results1 files ±0 4 suites ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2348c7d. ± Comparison against base commit 07c5394. ♻️ This comment has been updated with latest results. |
node-red:3.1.x-main-linux-arm64 scan results3 tests +3 0 ✅ ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2348c7d. ± Comparison against base commit 07c5394. ♻️ This comment has been updated with latest results. |
forge-k8s:main-linux-amd64 scan results1 tests ±0 0 ✅ ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2348c7d. ± Comparison against base commit 07c5394. ♻️ This comment has been updated with latest results. |
node-red:2.2.3-main-linux-arm64 scan results 1 files ±0 4 suites ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2348c7d. ± Comparison against base commit 07c5394. This pull request removes 10 and adds 16 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
forge-k8s:main-linux-arm64 scan results1 tests ±0 0 ✅ ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2348c7d. ± Comparison against base commit 07c5394. ♻️ This comment has been updated with latest results. |
Looks fine, just two small suggestions in the secrets naming convention. |
Description
This allows K8s to use cert-manager.io to issue TLS certs for both the core Forge apps and the Instances.
Related Issue(s)
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label