Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add possibility to provide database credentials as an external secret #296

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

ppawlowski
Copy link
Contributor

Description

This PR adds a possibility to provide database credentials as a Kubernetes secret created outside of the Helm chart.

Related Issue(s)

#290

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb February 5, 2024 18:48
Copy link

github-actions bot commented Feb 5, 2024

node-red:3.1.x-main-linux-amd64 scan results

6 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
1 files   ±0   6 ❌ ±0 

For more details on these failures, see this check.

Results for commit eae694d. ± Comparison against base commit c1bb99e.

Copy link

github-actions bot commented Feb 5, 2024

node-red:2.2.3-main-linux-amd64 scan results

26 tests  ±0    0 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0   26 ❌ ±0 

For more details on these failures, see this check.

Results for commit eae694d. ± Comparison against base commit c1bb99e.

Copy link

github-actions bot commented Feb 5, 2024

node-red:3.0.2-main-linux-amd64 scan results

1 files  ±0  4 suites  ±0   0s ⏱️ ±0s
7 tests ±0  0 ✅ ±0  0 💤 ±0  7 ❌ ±0 
8 runs  ±0  0 ✅ ±0  0 💤 ±0  8 ❌ ±0 

For more details on these failures, see this check.

Results for commit eae694d. ± Comparison against base commit c1bb99e.

Copy link

github-actions bot commented Feb 5, 2024

file-server:main-linux-amd64 scan results

1 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ ±0 

For more details on these failures, see this check.

Results for commit eae694d. ± Comparison against base commit c1bb99e.

Copy link

github-actions bot commented Feb 5, 2024

node-red:3.0.2-main-linux-arm64 scan results

1 files  ±0  4 suites  ±0   0s ⏱️ ±0s
7 tests ±0  0 ✅ ±0  0 💤 ±0  7 ❌ ±0 
8 runs  ±0  0 ✅ ±0  0 💤 ±0  8 ❌ ±0 

For more details on these failures, see this check.

Results for commit eae694d. ± Comparison against base commit c1bb99e.

Copy link

github-actions bot commented Feb 5, 2024

node-red:2.2.3-main-linux-arm64 scan results

26 tests  ±0    0 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0   26 ❌ ±0 

For more details on these failures, see this check.

Results for commit eae694d. ± Comparison against base commit c1bb99e.

Copy link

github-actions bot commented Feb 5, 2024

forge-k8s:main-linux-amd64 scan results

1 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ ±0 

For more details on these failures, see this check.

Results for commit eae694d. ± Comparison against base commit c1bb99e.

Copy link

github-actions bot commented Feb 5, 2024

node-red:3.1.x-main-linux-arm64 scan results

6 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
1 files   ±0   6 ❌ ±0 

For more details on these failures, see this check.

Results for commit eae694d. ± Comparison against base commit c1bb99e.

Copy link

github-actions bot commented Feb 5, 2024

file-server:main-linux-arm64 scan results

1 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ ±0 

For more details on these failures, see this check.

Results for commit eae694d. ± Comparison against base commit c1bb99e.

Copy link

github-actions bot commented Feb 5, 2024

forge-k8s:main-linux-arm64 scan results

1 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   1 ❌ ±0 

For more details on these failures, see this check.

Results for commit eae694d. ± Comparison against base commit c1bb99e.

@hardillb hardillb merged commit 23a0f51 into main Feb 6, 2024
41 checks passed
@hardillb hardillb deleted the feat-external-secrets branch February 6, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants