Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Separate project's and core app ingress annotations #511

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

ppawlowski
Copy link
Contributor

Description

This pull request separates the ingress annotations for the project's (NR instances) and the core application.
Custom annotations for NR instances can now be defined using the forge.projectIngressAnnotation variable.
To prevent breaking changes, the existing ingress.annotations will continue to be used as the value for the INGRESS_ANNOTATIONS environment variable within the core application if forge.projectIngressAnnotation is not defined.

Related Issue(s)

Closes #475

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb December 2, 2024 18:43
@hardillb hardillb merged commit 4cfc0f1 into main Dec 3, 2024
8 checks passed
@hardillb hardillb deleted the fix-ingress-annotations branch December 3, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to seperate FlowFuse app Ingress Annoations from NR Instance Ingress Annotations
2 participants