Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fix javadoc #185

Merged
merged 4 commits into from
Nov 6, 2024
Merged

[2.x] Fix javadoc #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5625e6
build: upgrade lombok to 1.18.34
javier-godoy Nov 5, 2024
d64061e
build: upgrade javadoc plugin to 3.11.1
javier-godoy Nov 5, 2024
219429c
docs: fix javadoc warnings
javier-godoy Nov 6, 2024
e4c5db2
ci: configure Javadoc failOnWarnings
javier-godoy Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.24</version>
<version>1.18.34</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -246,10 +246,10 @@
</execution>
</executions>
</plugin>
<plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.0.1</version>
<version>3.11.1</version>
<executions>
<execution>
<id>attach-javadocs</id>
Expand All @@ -262,6 +262,10 @@
<configuration>
<quiet>true</quiet>
<doclint>none</doclint>
<failOnWarnings>true</failOnWarnings>
<links>
<link>https://javadoc.io/doc/com.vaadin/vaadin-platform-javadoc/${vaadin.version}</link>
</links>
</configuration>
</plugin>
<plugin>
Expand Down
12 changes: 6 additions & 6 deletions src/main/java/com/flowingcode/vaadin/addons/twincolgrid/TwinColGrid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public enum Orientation {
private boolean isFromClient = false;

private String layoutId;

private static <T> ListDataProvider<T> emptyDataProvider() {
return DataProvider.ofCollection(new LinkedHashSet<>());
}
Expand Down Expand Up @@ -308,7 +308,7 @@ public TwinColGrid(@NonNull Grid<T> availableGrid, @NonNull Grid<T> selectionGri
/**
* Sets the component caption.
*
* @param captinText the component caption.
* @param captionText the component caption.
*/
public void setCaption(String captionText) {
if (captionText != null) {
Expand Down Expand Up @@ -339,7 +339,7 @@ public String getCaption() {
* Sets orientation for TwinColGridComponent
*
* @param orientation
* @return
* @return this instance for method chaining.
*/
public TwinColGrid<T> withOrientation(Orientation orientation) {
if (this.orientation != orientation) {
Expand Down Expand Up @@ -393,10 +393,10 @@ private Component createContainerLayout() {

private String getLayoutId() {
return Optional.ofNullable(layoutId).orElseGet(()->{
return this.layoutId = "twincol-" + UUID.randomUUID();
return layoutId = "twincol-" + UUID.randomUUID();
});
}

private HorizontalLayout createHorizontalContainer(boolean reverse) {
buttonContainer = getVerticalButtonContainer();
HorizontalLayout hl;
Expand Down Expand Up @@ -676,7 +676,7 @@ public TwinColGrid<T> addSortableColumn(
* @param itemLabelGenerator the value provider
* @param comparator the in-memory comparator
* @param header the column header
* @param header the column key
* @param key the column key
* @return this instance
*/
public TwinColGrid<T> addSortableColumn(
Expand Down
Loading