New Architecture support

[johnf]

Description

First apologies for the amount of change in this PR. I don't expect it to be accepted at all in it's current form. I'm happy to work on getting it in a saner stated if needed.

I've just started using react-native-owl, so much easier than detox that I was using before.

However I was having issues with screenshots when using the React Native new architecture.

Immersive mode wasn't working.

I started working on supporting the new arch; I ended up basically trying to align everything with react-native-create-library to get it to work (as I use it for another library I work on), hence why there is so much change.

Something I discovered when I was almost done converting to TurboModules, is that on new arch you need to call TurboModuleRegistry.get otherwise the initialize doesn't load.

I've test this on the unreleased monorepo version of react-native-vector icons and it's working well for me.

Not all the tests are working yet, some issues with mocking.

I though I'd open this for feedback before I spent more time on it.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

In theory this should be fully backwards compatible and not breaking.

How Has This Been Tested?

I've tested against react-native-vector-icons, I'll work on the inbuilt test suite next.

Checklist: (Feel free to delete this section upon completion)

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My code follows the style guidelines of this project (I have run yarn prettier:apply)
• [] I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes (I have run yarn test)
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[changeset-bot]

⚠️ No Changeset found

Latest commit: ee54940

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-owl	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 0:09am