Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gourmet/knp-menu with icings/menu. #264

Merged

Conversation

ndm2
Copy link
Contributor

@ndm2 ndm2 commented May 12, 2017

gourmet/knp-menu doesn't seem to be maintained anymore, just like Gourmet in general.

Given the current state, I'd like to propose replacing gourmet/knp-menu with icings/menu, which is based on KnpMenu too, and ships with a string template renderer, and URL as well as route based matching.

I've used it for internal projects for quite some time now, but had to make some larger changes for the public release, so it's currently in beta. Not sure what the rules regarding stability are, but I thought throwing the idea in the room before the first stable won't hurt.

ping @Phillaf

@ADmad
Copy link
Member

ADmad commented May 12, 2017

You have my vote for replacing gourmet/knp-menu. As you mentioned gourmet's plugin's aren't being maintained. Given that your plugin has 100% code coverage the beta status of the plugin is not an issue.

One thing I noticed in the docs example is it says for ['controller' => 'Articles', 'action' => 'index'] the URL generated /articles/index, is that correct? As per Cake's default routes it should be /articles.

@ndm2
Copy link
Contributor Author

ndm2 commented May 12, 2017

Not quite correct, no, intially this was all using this "neutral" 'controller' => 'Controller', 'action' => 'action' config, and I just didn't update that properly in some places. Fixed now.

@Phillaf
Copy link

Phillaf commented May 12, 2017

Just here to second everything you guys said. Gourmet's plugin have never been working correctly in the first place.

@ADmad ADmad merged commit f096da7 into FriendsOfCake:master May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants