Bug Report: Game crash if you are in charting mode and get the fakeout death

[snipekitty]

Please check for duplicates or similar issues, as well performing simple troubleshooting steps (such as clearing cookies, clearing AppData, trying another browser) before submitting an issue.

If you are playing the game in a browser, what site are you playing it from?

• Newgrounds
• Itch.io? Specify below
• • Windows
• • Mac
• • Linux

If you are playing the game in a browser, what browser are you using?

• Google Chrome (or chomium based like Brave, vivaldi, MS Edge)
• Firefox
• Safari

What version of the game are you using? Look in the bottom left corner of the main menu. (ex: 0.2.7, 0.2.1, shit like that)

version 0.3.3

Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.

Please describe your issue. Provide extensive detail and images if possible.

If you want to recreate the error, go to GameOverSubState.hx (and i have to add you can only change GameOverSubState in source code) and edit the code on line 204 to make you have a higher chance to get the fakeout (ex: " if (boyfriend.hasAnimation('fakeoutDeath') && FlxG.random.bool((1 / 1) * 1000)) " and then enter a song that uses base boyfriend (so not any songs in week 4, week 5, or week 6) go into the chart editor, playtest, and die, the game will crash or softlock.

This is the error that you get in the terminal.

2024-05-18.21-56-11.mp4

this is a video showing the bug happening in real time. The errors appeared after trying to exit to the menu (or pressing backspace)

If you're game is FROZEN and you're playing a web version, press F12 to open up browser dev window, and go to console, and copy-paste whatever red error you're getting

[Hundrec]

Are you able to reproduce this in 0.5.3?

[snipekitty]

Are you able to reproduce this in 0.5.3?

ill try to reproduce it as soon as possible in the newest version

[snipekitty]

still happens in 0.5.2, I can't reliably test in 0.5.3 until source code releases

[Hundrec]

Thanks for testing!

[NotHyper-474]

Weird, I'm using the 0.5.3 source code (technically it's just the one on the develop branch) and can't reproduce this.

[snipekitty]

Weird, I'm using the 0.5.3 source code (technically it's just the one on the develop branch) and can't reproduce this.

really? possibly got fixed?

[Hundrec]

There shouldn't be a difference between 0.5.2 and 0.5.3, so we'll need further testing with this

[NotHyper-474]

I've been looking into this and managed to reproduce it reliably and find what's causing it.
The problem is that BF's character code expects the current substate to be the game over one, but when we're playing from the chart editor the substate is the PlayState.

The patch below fixes it, but I personally don't like how it turned out.

     var bfFakeout:FlxAtlasSprite = new FlxAtlasSprite(this.x - 440, this.y - 240, Paths.animateAtlas("characters/bfFakeOut", "shared"));
-    FlxG.state.subState.add(bfFakeout);
+    var goState:FlxState = FlxG.state.subState;
+    if (goState.subState != null) {
+        // Hack to when we're playing via the Chart Editor
+        goState = goState.subState;
+    }
+    goState.add(bfFakeout);
     bfFakeout.zIndex = 1000;
     bfFakeout.playAnimation('');
     // We don't want people to miss this.
-    FlxG.state.subState.mustNotExit = true;
+    goState.mustNotExit = true;
     bfFakeout.onAnimationComplete.add(() -> {
       bfFakeout.visible = false;
       this.visible = true;
-      FlxG.state.subState.mustNotExit = false;
+      goState.mustNotExit = false;
       this.playAnimation('firstDeath', true, true);