Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix error when getting fakeout death while testing in Chart Editor #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NotHyper-474
Copy link

@NotHyper-474 NotHyper-474 commented Feb 26, 2025

Does this PR fixes/closes any issues?

Fixes FunkinCrew/Funkin#2554

Briefly describe the issue(s) fixed.

The script would always suppose the current state's substate was the GameOverSubState which isn't the case when you're in the chart editor.
This changes it so it gets the game over substate directly from the singleton.

@NotHyper-474 NotHyper-474 changed the title [BUGFIX] Error when getting fakeout death while testing in Chart Editor [BUGFIX] Fix error when getting fakeout death while testing in Chart Editor Feb 26, 2025
@NotHyper-474 NotHyper-474 force-pushed the bugfix/fakeout-chart-death branch from 9d5cb4a to 2491cb2 Compare February 26, 2025 17:47
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. chart editor PR is related to the operation of the Chart Editor. status: pending triage The bug or PR has not been reviewed yet. size: small A small pull request with 10 or fewer changes labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart editor PR is related to the operation of the Chart Editor. size: small A small pull request with 10 or fewer changes status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Game crash if you are in charting mode and get the fakeout death
2 participants