Actually complete notestyle data #2645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relevent -> relevant
…proper data for noteSplash and noteHoldCover
…/KutikiPlayz/Funkin into actually-complete-notestyle-data
…thub.com/KutikiPlayz/Funkin into actually-complete-notestyle-data" This reverts commit 3418775, reversing changes made to 18ebb64.
biomseed
approved these changes
Jun 3, 2024
PurSnake
added a commit
to PurSnake/Funkin_res
that referenced
this pull request
Jun 7, 2024
maybe more readable NoteStyle shit
KutikiPlayz
changed the title
EliteMasterEric
added
status: pending triage
KutikiPlayz
changed the title
KutikiPlayz
changed the title
EliteMasterEric
added
the
size: large
That PR has been merged internally and should appear in the next update, I think it's safe to do chart editor stuff now. (unless you want to wait for the next update?) |
|
I know it's merged internally, I'm waiting for the update so I can actually work with the new code and stuff |
|
I'm gonna be so real this pr is just so fuckin massive and does so many different things that could/should be handled by the actual devs or other smaller prs so I'm gonna split this up into smaller things that are more reasonable for prs also cuz I don't wanna have to maintain this massive ass thing hoping they pull |
Hundrec
added
status: stale
AbnormalPoof
added
the
status: rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds proper animation data for noteSplash and holdNoteCover asset types, as well as fixing scale, offsets, and assetPath on all asset types.
Also scoots note splashes slightly to the right to properly center them.
Probably gonna wait to see if #2635 is pulled before touching anything chart editor related. Shits a hardcoded mess as far as note styles goes and that pr makes some very helpful changes.
The only thing not implemented for the chart editor is proper scale for normal notes (sustains have scale implemented already), and offsets for notes and sustains.