Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recycle Credit Lines #2655

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Recycle Credit Lines #2655

wants to merge 1 commit into from

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented Jun 6, 2024

this pr changes the behaviour of the credits line, to not be all created at the beginning, but rather that they get recycled once a new line appears on the screen.
this should improve memory usage, especially when backers entries are supported

CyndaReal
CyndaReal approved these changes Jun 7, 2024
View reviewed changes
Copy link

@CyndaReal CyndaReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EliteMasterEric EliteMasterEric added status: pending triage Awaiting review. status: reviewing internally Under consideration and testing. type: optimization Involves a performance issue or a bug which causes lag. and removed status: pending triage Awaiting review. labels Jun 17, 2024
@lemz1 lemz1 changed the title [FEATURE] Recycle Credit Lines Recycle Credit Lines Jun 22, 2024
@EliteMasterEric EliteMasterEric added the size: medium A medium pull request with 100 or fewer changes. label Jul 11, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@ninjamuffin99 ninjamuffin99 force-pushed the develop branch 2 times, most recently from e0b1b01 to 410cfe9 Compare October 4, 2024 01:25
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed size: medium A medium pull request with 100 or fewer changes. labels Oct 8, 2024
@lemz1 lemz1 force-pushed the credits-state-recycle branch from b219a04 to 96d9f78 Compare October 21, 2024 18:10
@lemz1 lemz1 force-pushed the credits-state-recycle branch 2 times, most recently from 014b77f to 71d0706 Compare January 23, 2025 22:16
@lemz1 lemz1 force-pushed the credits-state-recycle branch from 71d0706 to 90088f3 Compare February 1, 2025 16:32
@github-actions github-actions bot added large and removed large labels Feb 1, 2025
@lemz1 lemz1 force-pushed the credits-state-recycle branch from 90088f3 to 3543876 Compare February 1, 2025 16:35
@github-actions github-actions bot added the large label Feb 1, 2025
@lemz1 lemz1 force-pushed the credits-state-recycle branch from 3543876 to 4254865 Compare February 18, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesisfeline charlesisfeline charlesisfeline approved these changes

@CyndaReal CyndaReal CyndaReal approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: reviewing internally Under consideration and testing. type: optimization Involves a performance issue or a bug which causes lag.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lemz1 @charlesisfeline @CyndaReal @EliteMasterEric