Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add the ability to flip the character in the Animation Editor #3028

Conversation

AbnormalPoof
Copy link
Collaborator

@AbnormalPoof AbnormalPoof commented Jul 14, 2024

This simple Pull Request adds the ability to horizontally flip the character in the Animation Editor (By pressing G). This can help a lot, especially when setting offsets for playable characters! Should be a decent quality-of-life feature.

I've created a PR on the assets repository (see funkin.assets#60) to add the keybind to the Shortcuts list.

anim.editor.flippin.mp4

@Keoiki
Copy link
Contributor

Keoiki commented Jul 15, 2024

How did they manage to forget a feature this simple, like seriously.

@AbnormalPoof
Copy link
Collaborator Author

AbnormalPoof commented Oct 3, 2024

Just tested the PR on v0.5.1 and it still works.
Can't get a video rn though unfortunately since I don't have my SSD with me.

@ninjamuffin99 ninjamuffin99 force-pushed the develop branch 2 times, most recently from e0b1b01 to 410cfe9 Compare October 4, 2024 01:25
@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Oct 6, 2024
@AbnormalPoof AbnormalPoof force-pushed the feature/animation-editor-flipping branch from 897f663 to 21078c6 Compare October 8, 2024 19:19
@AbnormalPoof
Copy link
Collaborator Author

Everything is one commit now thank god

@Hundrec Hundrec added the type: enhancement Involves an enhancement or new feature. label Jan 22, 2025
@AbnormalPoof AbnormalPoof force-pushed the feature/animation-editor-flipping branch from c7e2f80 to 557a7bf Compare January 26, 2025 15:55
@AbnormalPoof
Copy link
Collaborator Author

I've rebased this branch to sit on top of develop since I realized it was 1000 commits behind...

@EliteMasterEric EliteMasterEric force-pushed the feature/animation-editor-flipping branch from 557a7bf to 0a6f142 Compare February 18, 2025 04:29
@EliteMasterEric EliteMasterEric added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Feb 18, 2025
@EliteMasterEric EliteMasterEric added this to the 0.6.0 (Pit Stop 2) milestone Feb 18, 2025
@EliteMasterEric EliteMasterEric merged commit de02137 into FunkinCrew:develop Feb 18, 2025
4 checks passed
@AbnormalPoof AbnormalPoof deleted the feature/animation-editor-flipping branch February 18, 2025 04:32
@AbnormalPoof AbnormalPoof added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants