Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCUMENTATION] playSound Typo in NoteScriptEvent #3282

Merged
merged 2 commits into from
Sep 21, 2024
Merged

[DOCUMENTATION] playSound Typo in NoteScriptEvent #3282

merged 2 commits into from
Sep 21, 2024

Conversation

TechnikTil
Copy link
Contributor

Does this PR close any issues? If so, link them below.

Briefly describe the issue(s) fixed.

This PR corrects a typo on the documentation of playSound in NoteScriptEvent.

What's up y'all, its TechnikTil coming back with another typo lets go baby

@Hundrec
Copy link
Collaborator

Hundrec commented Sep 16, 2024

Important, needs to be merged ASAP

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Sep 16, 2024
@TechnikTil TechnikTil changed the title playSound Documentation Typo [DOCUMENTATION] playSound Typo in NoteScriptEvent Sep 17, 2024
@EliteMasterEric EliteMasterEric added type: documentation Involves improvements or additions to documentation. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Sep 21, 2024
@EliteMasterEric EliteMasterEric merged commit 3ef238a into FunkinCrew:develop Sep 21, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.1 milestone Sep 22, 2024
@Hundrec Hundrec added size: small A small pull request with 10 or fewer changes. pr: documentation PR modifies documentation or README files. pr: haxe PR modifies game code. and removed type: documentation Involves improvements or additions to documentation. pr: documentation PR modifies documentation or README files. labels Jan 22, 2025
@Hundrec Hundrec added the type: chore Involves minor adjustments that do not make functional changes. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: chore Involves minor adjustments that do not make functional changes.
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@TechnikTil @Hundrec @EliteMasterEric