Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Outdated Mods #3447

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Show Outdated Mods #3447

wants to merge 1 commit into from

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented Sep 24, 2024

ADDITIONS AND CHANGES

This pr adds an alert for outdated mods at the start of the program.

PREVIEW

image

@lemz1 lemz1 changed the base branch from main to develop September 24, 2024 18:28
@AbnormalPoof
Copy link
Collaborator

I feel like for something like this, it might be better to use PolymodErrorHandler's showAlert function. Something like this maybe:
Screenshot 2024-09-24 at 4 17 33 PM
I'm not against the current implementation, though.

@lemz1
Copy link
Contributor Author

lemz1 commented Sep 24, 2024

I feel like for something like this, it might be better to use PolymodErrorHandler's showAlert function. Something like this maybe:

Screenshot 2024-09-24 at 4 17 33 PM

I'm not against the current implementation, though.

Yeah its probably better with the showAlert thing, but i wasn't sure if it would look good if alot of mods are outdated, so i just immediately went with haxe-ui, since it implements a scrollable view.

Maybe we can get Eric's feedback on which method is better.

@EliteMasterEric
Copy link
Member

I definitely prefer the showAlert method, and having it display every time rather than the first time so we don't need to write anything to save data.

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Sep 25, 2024
@lemz1
Copy link
Contributor Author

lemz1 commented Sep 25, 2024

I definitely prefer the showAlert method, and having it display every time rather than the first time so we don't need to write anything to save data.

Updated the pr to use showAlert, as well as showing outdated mods always

@ninjamuffin99 ninjamuffin99 force-pushed the develop branch 2 times, most recently from e0b1b01 to 410cfe9 Compare October 4, 2024 01:25
@github-actions github-actions bot added pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. labels Oct 8, 2024
@Hundrec Hundrec added the type: enhancement Involves an enhancement or new feature. label Jan 22, 2025
@lemz1 lemz1 force-pushed the mod-info branch 6 times, most recently from 44cefa1 to b577fc2 Compare January 23, 2025 22:16
@github-actions github-actions bot added medium and removed medium labels Feb 1, 2025
Copy link
Collaborator

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@AbnormalPoof AbnormalPoof added the topic: mods Related to the creation or use of mods. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants