Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation: OutdatedSubState (OutdatedState) #3473

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented Sep 27, 2024

ADDITIONS

This pr adds the implementation for the OutdatedSubState. (Well now its OutdatedState)
It checks the html of the itch.io page and retrieves the versions.

It uses HtmlParser to parse the HTML.

NOTE

I wanted to use the itch.io API but for the love of it, I couldn't find a way to retrieve a list of the uploaded files. If anyone knows how to retrieve them, then please share, because i don't like that we parse HTML to retrieve the versions. It's probably slow and unsafe.

PREVIEW

screenshot-2024-09-27-21-32-56

I do wonder if changing it to be an alert would be better. I just went with the old implementation of the OutdatedSubState

@lemz1 lemz1 changed the title Implementation: OutdatedSubState Implementation: OutdatedSubState (OutdatedState) Sep 27, 2024
@ninjamuffin99
Copy link
Member

I think for this we would want to update it to use the itch.io api, so then stuff like mac version will check if theres a mac version update, windows can check windows, linux can check linux, etc.

havent looked too deep into that api yet, but we do want this screen back in some form !

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Oct 1, 2024
@lemz1
Copy link
Contributor Author

lemz1 commented Oct 1, 2024

I think for this we would want to update it to use the itch.io api, so then stuff like mac version will check if theres a mac version update, windows can check windows, linux can check linux, etc.

havent looked too deep into that api yet, but we do want this screen back in some form !

sounds good to me. Will need to look into the itch.io api and see how i can retrieve the versions

@lemz1 lemz1 marked this pull request as draft October 1, 2024 13:18
@lemz1 lemz1 marked this pull request as ready for review October 1, 2024 17:04
@ninjamuffin99 ninjamuffin99 force-pushed the develop branch 2 times, most recently from e0b1b01 to 410cfe9 Compare October 4, 2024 01:25
@github-actions github-actions bot added pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. labels Oct 8, 2024
@Hundrec Hundrec added the type: enhancement Involves an enhancement or new feature. label Jan 22, 2025
@github-actions github-actions bot added the pr: documentation PR modifies documentation or README files. label Jan 22, 2025
@Hundrec Hundrec removed the pr: documentation PR modifies documentation or README files. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants