[feature/automatic-offset-flipping] Attribute Is Facing Right

[lemz1]

• Automatically flip character offsets (+ some rewrites to character data) #3539 Automatic character offset flipping isn't 100% working yet

FIXES / CHANGES

• Adds isFacingRight attribute to character data
• Reverts tankman.json

By using isFacingRight, we can fix the problem of wrong animations and broken offsets

Default is true

if a character seems to have broken offsets, set isFacingRight to false, and see if that fixes it.

[EliteMasterEric]

Why can't you just use the default value of flipX?

[lemz1]

lets look at tankman as an example:
_data.flipX is true,
and his offsets are made for when he is the opponent

problem:
when he is the opponent BaseCharacter.flipX is true,
we implemented it that when flipX is true we need to flip offsets and anims,
however this shouldn't happen here, since his offsets and anims are already correct.
Exactly for this reason i added the isFacingRight attribute

note:
im pretty sure this is what that animOffsets[0] *= -1
CharacterRegistry was for, however that is an incorrect calculation

[EliteMasterEric]

we implemented it that when flipX is true we need to flip offsets and anims,

But the funkin.play.stage.Stage#addCharacter() function data applies either the flipX value, or the inverse of that value!

So if a character has flipX = true in their data, then BaseCharacter.flipX will become false when they switch sides.

animOffsets[0] *= -1 is supposed to account for this, but if that calculation is incorrect, then we just need to apply the correct one.

[lemz1]

But the funkin.play.stage.Stage#addCharacter() function data applies either the flipX value, or the inverse of that value!

So if a character has flipX = true in their data, then BaseCharacter.flipX will become false when they switch sides.

it only swaps when its the character is on the player side,
but thats a problem for tankman since he will have BaseCharacter.flipX set to false, meaning it won't flip the offsets because we check if BaseCharacter.flipX is true and only then flip offsets and anims

[lemz1]

the calculation we actually need is one similar to this:

Funkin/source/funkin/play/stage/Bopper.hx

Line 373 in fb4bbba

output.x += (animOffsets[0] * 2 + (width - frameWidth)) * this.scale.x;

[lemz1]

but im pretty sure even if we have the correct calculation, there will still be edge cases.
so i might just write a python script to automatically set isFacingRight to the correct value (just need to hope there is some library that can help me do that, although i kinda doubt that such a library exists)

[EliteMasterEric]

the calculation we actually need is one similar to this:

Funkin/source/funkin/play/stage/Bopper.hx

Line 373 in fb4bbba

output.x += (animOffsets[0] * 2 + (width - frameWidth)) * this.scale.x;

I see, I should test this change out later.

[EliteMasterEric]

but thats a problem for tankman since he will have BaseCharacter.flipX set to false, meaning it won't flip the offsets because we check if BaseCharacter.flipX is true and only then flip offsets and anims

That's what the anim.offsets flip in the CharacterRegistry is for!

[lemz1]

That's what the anim.offsets flip in the CharacterRegistry is for!

yeah, but the calculation is wrong

[lemz1]

i'll close this since #3543 does it nicer, and also has some other useful stuff