Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Test Pull Request + Documentation Fixes #3585

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

Hundrec
Copy link
Collaborator

@Hundrec Hundrec commented Oct 5, 2024

The latest Pull Request was actually labeled by GitHub Actions, so this PR tests it again.

I actually noticed a few things that needed changing, so I've made valid changes that Eric should take a look at:

@github-actions github-actions bot added the size: small A small pull request with 10 or fewer changes. label Oct 5, 2024
@github-actions github-actions bot added the pr: documentation PR modifies documentation or README files. label Oct 5, 2024
@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Oct 5, 2024

I wonder why there's a separate label for documentation instead of just using the type: documentation label.
Screenshot 2024-10-04 at 11 30 19 PM
Maybe to separate PRs that edit the source code and PRs that edit the .md files? I'm not really sure.

@Hundrec
Copy link
Collaborator Author

Hundrec commented Oct 5, 2024

Good point!
I was going to change the label until I saw your edit
I'll just let Eric handle the best way to label things.

@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. and removed size: small A small pull request with 10 or fewer changes. labels Oct 5, 2024
@Hundrec
Copy link
Collaborator Author

Hundrec commented Oct 5, 2024

Just realized that the size labels take the sum of additions and deletions.
5 line changes = 10 changes = medium
Noting this here so Eric can decide what a small/medium PR really is.

@Hundrec Hundrec changed the title Test Documentation Pull Request GitHub Actions Test Pull Request + Documentation Fixes Oct 5, 2024
Those stars might have been indicators for something, but I don't see any note related to them.
@LukerUpgradez
Copy link

I noticed the all-caps issue with the troubleshooting link a couple days ago but never got around to trying to fix it. Thanks for taking care of that!

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Oct 8, 2024
@EliteMasterEric
Copy link
Member

Maybe to separate PRs that edit the source code and PRs that edit the .md files? I'm not really sure.

documentation labels those PRs that edit .md files and haxe labels those PRs that edit .hx files. I think this is fine as is because some pull request modify both.

@EliteMasterEric EliteMasterEric changed the base branch from main to develop October 8, 2024 18:13
@EliteMasterEric EliteMasterEric merged commit 31d1b3e into FunkinCrew:develop Oct 8, 2024
2 checks passed
@EliteMasterEric EliteMasterEric added this to the 0.5.2 milestone Oct 12, 2024
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: documentation Involves improvements or additions to documentation. pr: github PR modifies GitHub metadata files. and removed status: pending triage Awaiting review. labels Jan 22, 2025
@Hundrec Hundrec deleted the labeler-test branch January 26, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: documentation PR modifies documentation or README files. pr: github PR modifies GitHub metadata files. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: documentation Involves improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation guide: "Great for fast iteration, but the game-"
4 participants