Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore: Blacklist an additional class in Polymod." #3729

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Revert "chore: Blacklist an additional class in Polymod." #3729

merged 1 commit into from
Feb 18, 2025

Conversation

AbnormalPoof
Copy link
Collaborator

Reverts #3607

The FunkinTypeResolver class was removed in the develop branch, so there's no need for this blacklist anymore.

@github-actions github-actions bot added size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. and removed size: small A small pull request with 10 or fewer changes. labels Oct 18, 2024
@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jan 17, 2025
@Hundrec Hundrec added type: documentation Involves improvements or additions to documentation. pr: documentation PR modifies documentation or README files. size: small A small pull request with 10 or fewer changes. and removed type: documentation Involves improvements or additions to documentation. pr: documentation PR modifies documentation or README files. labels Jan 22, 2025
@AbnormalPoof AbnormalPoof force-pushed the revert-3607-chore/more-blacklisted-classes branch from 46ad19a to dae1c19 Compare January 26, 2025 16:02
@Hundrec Hundrec added the type: security vulnerability Involves a security vulnerability within the game. label Feb 4, 2025
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Feb 18, 2025
@EliteMasterEric EliteMasterEric self-assigned this Feb 18, 2025
@EliteMasterEric EliteMasterEric added this to the 0.6.0 (Pit Stop 2) milestone Feb 18, 2025
@EliteMasterEric EliteMasterEric merged commit 06c12e3 into FunkinCrew:develop Feb 18, 2025
5 checks passed
@AbnormalPoof AbnormalPoof deleted the revert-3607-chore/more-blacklisted-classes branch February 18, 2025 01:44
@EliteMasterEric EliteMasterEric removed their assignment Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: security vulnerability Involves a security vulnerability within the game.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.
3 participants
@AbnormalPoof @EliteMasterEric @Hundrec