[BUGFIX] Actually check if the Playable Character is unlocked #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr: haxe
2 tasks
AbnormalPoof
force-pushed
the
bugfix/pico-autounlock
branch
from
d81d105 to
b80a6ee
Compare
EliteMasterEric
force-pushed
the
bugfix/pico-autounlock
branch
from
b80a6ee to
e30cbb7
Compare
EliteMasterEric
added
status: accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Fixes #3747
Briefly describe the issue(s) fixed.
CharSelectSubStatenever actually checked to see if the playable character was unlocked before pushing them tononLocks(to play the unlock animation). The only thing it did was check to see if the playable character ID was inSave.instance.charactersSeen, if it wasn't, it would be pushed tononLocksand still play the unlock animation despite never actually unlocking them.This, in turn, basically unlocked Pico right from the get-go if you entered the Character Select screen early, whether it be through a modded Playable Character, or the Debug Menu.
Include any relevant screenshots or videos.
Now, Pico remains locked (since WeekEnd 1 was never beaten), while Madoka (a modded playable character) is unlocked.