Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX]: Results Screen Debug Feature Removal #3848

Closed
wants to merge 2 commits into from

Conversation

JVNpixels
Copy link
Contributor

@JVNpixels JVNpixels commented Nov 10, 2024

Does this PR close any issues? If so, link them below.

#3845

Briefly describe the issue(s) fixed.

This PR removes the debug feature of moving the text left and right (most likely a test to see how the text functions) but it was still left in release builds, so this PR removes that feature.

Include any relevant screenshots or videos.

IMG_7349

@github-actions github-actions bot added pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. labels Nov 10, 2024
@amyspark-ng
Copy link
Contributor

why not leave it in debug builds instead of commenting?

@JVNpixels
Copy link
Contributor Author

why not leave it in debug builds instead of commenting?

This is a better idea actually, I was gonna do that but wasn’t sure whether to leave it as a debug only feature or make it a comment, but now that I think of it, it would be better as a debug only feature

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jan 17, 2025
@Hundrec Hundrec added the type: minor bug Involves a minor bug or issue. label Jan 22, 2025
@Lasercar
Copy link
Contributor

This has been resolved internally?
#3845

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 12, 2025

I'll close this one then.

@Hundrec Hundrec closed this Feb 12, 2025
@Hundrec Hundrec added status: rejected Issue did not pass review or PR cannot be approved. and removed type: minor bug Involves a minor bug or issue. status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants