Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add missing comments to 3 functions in funkin.Assets #4056

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[DOCS] Add missing comments to 3 functions in funkin.Assets #4056

merged 1 commit into from
Feb 18, 2025

Conversation

AbnormalPoof
Copy link
Collaborator

This PR adds documentation for the last 3 functions in funkin.Assets, pretty self-explanatory. There were no comments for these functions in openfl.utils.Assets, so I had to write them myself.

If you have ideas for revisions, let me know!

@AbnormalPoof AbnormalPoof added status: pending triage Awaiting review. pr: documentation PR modifies documentation or README files. type: documentation Involves improvements or additions to documentation. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. and removed pr: documentation PR modifies documentation or README files. labels Jan 27, 2025
@Hundrec Hundrec added type: chore Involves minor adjustments that do not make functional changes. and removed type: documentation Involves improvements or additions to documentation. labels Feb 4, 2025
@AbnormalPoof AbnormalPoof changed the title Add missing comments to 3 functions in funkin.Assets chore: Add missing comments to 3 functions in funkin.Assets Feb 6, 2025
@EliteMasterEric EliteMasterEric added type: documentation Involves improvements or additions to documentation. and removed type: chore Involves minor adjustments that do not make functional changes. labels Feb 14, 2025
@AbnormalPoof AbnormalPoof changed the title chore: Add missing comments to 3 functions in funkin.Assets [DOCS] Add missing comments to 3 functions in funkin.Assets Feb 14, 2025
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Feb 18, 2025
@EliteMasterEric EliteMasterEric merged commit c06d794 into FunkinCrew:develop Feb 18, 2025
14 checks passed
@AbnormalPoof AbnormalPoof deleted the docs/funkin-assets-comments branch February 18, 2025 01:44
@EliteMasterEric EliteMasterEric added this to the 0.6.0 (Pit Stop 2) milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: documentation Involves improvements or additions to documentation.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.
3 participants
@AbnormalPoof @EliteMasterEric @Hundrec