Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix an inconsistency in one of the comments for Stage.hx #4096

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

AbnormalPoof
Copy link
Collaborator

When referring to FlxSprites in the comments, it's usually written as "an FlxSprite".

However, Stage.hx is the ONLY file to refer to FlxSprites as "a FlxSprite".
Literally fucking unplayable.
This PR fixes this grave mistake, making the game playable again. :)

(This PR also serves as a test to see if label actions are working properly again!)

@github-actions github-actions bot added pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. labels Feb 3, 2025
@AbnormalPoof AbnormalPoof added the type: documentation Involves improvements or additions to documentation. label Feb 3, 2025
@AbnormalPoof
Copy link
Collaborator Author

The labeler works properly now thank god

@Hundrec Hundrec added type: chore Involves minor adjustments that do not make functional changes. and removed type: documentation Involves improvements or additions to documentation. labels Feb 4, 2025
@Lasercar
Copy link
Contributor

Lasercar commented Feb 4, 2025

The labeler works properly now thank god

Oh good, so it'll no longer do this?
Screenshot 2025-02-04 185811
Screenshot 2025-02-04 185952

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 4, 2025

Hopefully all the labelers will work perfectly now.

@AbnormalPoof AbnormalPoof changed the title Fix an inconsistency in one of the comments for Stage.hx chore: Fix an inconsistency in one of the comments for Stage.hx Feb 6, 2025
@EliteMasterEric EliteMasterEric merged commit 6466b88 into FunkinCrew:develop Feb 14, 2025
6 checks passed
@AbnormalPoof AbnormalPoof deleted the test-pr-develop branch February 14, 2025 23:16
@AbnormalPoof AbnormalPoof added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Feb 14, 2025
@AbnormalPoof AbnormalPoof added this to the 0.6.0 (Pit Stop 2) milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: chore Involves minor adjustments that do not make functional changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants