Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Faster scrolling in Freeplay #4103

Merged
merged 2 commits into from
Feb 18, 2025
Merged

[ENHANCEMENT] Faster scrolling in Freeplay #4103

merged 2 commits into from
Feb 18, 2025

Conversation

AbnormalPoof
Copy link
Collaborator

@AbnormalPoof AbnormalPoof commented Feb 4, 2025 •
edited
Loading

Inspired by this comment from Eric, HOME and END now jump to the top and bottom of the Freeplay menu respectively.

fast.freeplay.scrolling.mp4

If you have better names for the controls please let me know.

@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels Feb 4, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels Feb 4, 2025
@amyspark-ng
Copy link
Contributor

can we consider a "scroll to a random song" button?

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 5, 2025

Telling from Eric's comment in #3034, that's unlikely

@amyspark-ng
Copy link
Contributor

maybe he thought the idea was a keybind that specifically sends you to the random button, not the keybind that takes you to a random song

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 5, 2025

I agree that it could be cool
I'll see what he thinks...

@Hundrec
Copy link
Collaborator

Hundrec commented Feb 5, 2025

Eric thinks a random keybind would be redundant, but this PR is a good addition!

@amyspark-ng
Copy link
Contributor

is fine 😞

@EliteMasterEric EliteMasterEric removed the status: pending triage Awaiting review. label Feb 5, 2025
@Lasercar
Copy link
Contributor

Lasercar commented Feb 5, 2025

Aw man, you did it before me!

@Hundrec Hundrec added the status: reviewing internally Under consideration and testing. label Feb 5, 2025
@EliteMasterEric EliteMasterEric merged commit 87b1fc9 into FunkinCrew:develop Feb 18, 2025
2 checks passed
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Feb 18, 2025
@EliteMasterEric EliteMasterEric added this to the 0.6.0 (Pit Stop 2) milestone Feb 18, 2025
@AbnormalPoof AbnormalPoof deleted the speedy-freeplay-scrolling branch February 18, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotHyper-474 NotHyper-474 NotHyper-474 approved these changes

@charlesisfeline charlesisfeline charlesisfeline approved these changes

@Hundrec Hundrec Hundrec approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.
7 participants
@AbnormalPoof @amyspark-ng @Hundrec @Lasercar @NotHyper-474 @charlesisfeline @EliteMasterEric