Hold note still pressed after pausing, removing hold and resuming game fix

[Lasercar]

Does this PR close any issues? If so, link them below.

Fixes #2227

Briefly describe the issue(s) fixed.

Pressing a hold note then pausing the game without unpressing, then releasing your hold and resuming, results in the hold note still being pressed despite having removed your input.

This fixes it for a single hold note, but it probably doesn't work properly on multiple hold notes? I haven't tested it on multiple hold notes.

Include any relevant screenshots or videos.

2025-02-15.15-26-26.mp4

Whoops, I didn't rebuild after making the branch, lol. Ah whatever, who cares about that?

Weird issue - hold note being dropped after pressing alternative note inputs

2025-02-18.21-12-28.mp4

[AbnormalPoof]

LGTM

[EliteMasterEric]

Definitely test and make sure it works on multiple hold notes before requesting review again.

[Lasercar]

Definitely test and make sure it works on multiple hold notes before requesting review again.

I've just tested it on multiple hold notes and it definitely works, mostly.

I've noticed one thing where sometimes, it works for one hold note, but not the other one?

@Hundrec I've just uploaded it to the description.

I'll see if I can get a clip of the weird issue I mentioned.

[Hundrec]

I think that's what Eric meant

Can you record and send a video of the current behavior?

[Lasercar]

Ah, I think it's because of the alternative note inputs - notice how the down arrow hold doesn't work, after I pressed down a few times?

But then again, maybe it's just a me problem? nope.

[Hundrec]

In your videos, are you still holding the note while unpausing?

The behavior in the videos don't seem any different from 0.5.3

If so, can you record a video of Bopeebo without holding the note while unpausing?

[Lasercar]

In your videos, are you still holding the note while unpausing?

The behavior in the videos don't seem any different from 0.5.3

If so, can you record a video of Bopeebo without holding the note while unpausing?

Ah, yeah, I see another problem when I pause while holding, unhold, and then resume:

2025-02-18.18-49-27.mp4

Sometimes, a note hold still sticks?

I managed to fix this issue, but I'm still getting the other one mentioned above: #4145 (comment)

Where the first alternative input to be pressed causes that note to be dropped?

[Hundrec]

Yes, I believe this is what Eric meant.
Please mark this PR as a draft for now since it doesn't seem to fix the notes staying held

[Lasercar]

I think this is going to remain a draft for a while - I basically need a way to check if one of the keys is being held down and return if so but it turns out Just_Pressed and Pressed end up true at the same time (aka the first frame) when the key is pressed, so there's no way I can fix this issue atm:
https://haxeflixel.com/documentation/keyboard/

If there was another filter called Hold or something that only returns true after one frame has passed of the key being down, then I'd be able to fix the remaining issue.