Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Removed unused code from TitleState #4151

Merged
merged 1 commit into from
Feb 16, 2025
Merged

[CLEANUP] Removed unused code from TitleState #4151

merged 1 commit into from
Feb 16, 2025

Conversation

AbnormalPoof
Copy link
Collaborator

This code was used at one point during the Week 7 update, but now has been obsoleted by AttractState.

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. and removed status: pending triage Awaiting review. labels Feb 15, 2025
@AbnormalPoof AbnormalPoof added status: pending triage Awaiting review. type: chore Involves minor adjustments that do not make functional changes. labels Feb 15, 2025
Lasercar
Lasercar approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@Lasercar Lasercar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I didn't know that the teaser was handled by a different state and that it's named after what arcade machines do! Infact, it gave me the thought, does the Funkin Crew plan on making an arcade cabinet of the game?

@EliteMasterEric EliteMasterEric added this to the 0.6.0 (Pit Stop 2) milestone Feb 16, 2025
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Feb 16, 2025
@EliteMasterEric EliteMasterEric merged commit 6795c33 into FunkinCrew:develop Feb 16, 2025
7 checks passed
@AbnormalPoof AbnormalPoof deleted the netstream-thing-idk-man branch February 16, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lasercar Lasercar Lasercar approved these changes

@moxie-coder moxie-coder moxie-coder approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: chore Involves minor adjustments that do not make functional changes.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.
4 participants
@AbnormalPoof @Lasercar @moxie-coder @EliteMasterEric