Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix the difficulty graphic cutoff in the Results Screen #4161

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[BUGFIX] Fix the difficulty graphic cutoff in the Results Screen #4161

merged 1 commit into from
Feb 18, 2025

Conversation

AbnormalPoof
Copy link
Collaborator

Does this PR close any issues? If so, link them below.

Closes #2283

Briefly describe the issue(s) fixed.

Just one simple line change to move the mask shader more to the left.

Include any relevant screenshots or videos.

screenshot-2025-02-16-20-58-14

@AbnormalPoof AbnormalPoof added topic: polish Involves minor polish to the UI or gameplay. type: minor bug Involves a minor bug or issue. labels Feb 17, 2025
@github-actions github-actions bot added status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. labels Feb 17, 2025
@AbnormalPoof AbnormalPoof added status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. labels Feb 17, 2025
@AbnormalPoof AbnormalPoof changed the title [BUGFIX] Fix the difficulty graphic cutoff on the Results Screen [BUGFIX] Fix the difficulty graphic cutoff in the Results Screen Feb 17, 2025
@amyspark-ng
Copy link
Contributor

image
oh you mean this

JVNpixels
JVNpixels approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@JVNpixels JVNpixels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been frustrating me for so long, thank you for fixing this!

@EliteMasterEric
Copy link
Member

works

@EliteMasterEric EliteMasterEric merged commit b13bf05 into FunkinCrew:develop Feb 18, 2025
7 checks passed
@EliteMasterEric EliteMasterEric added this to the 0.6.0 (Pit Stop 2) milestone Feb 18, 2025
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Feb 18, 2025
@AbnormalPoof AbnormalPoof deleted the results-difficulty-cutoff branch February 18, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JVNpixels JVNpixels JVNpixels approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: polish Involves minor polish to the UI or gameplay. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.6.0 (Pit Stop 2)
Development

Successfully merging this pull request may close these issues.
5 participants
@AbnormalPoof @amyspark-ng @EliteMasterEric @JVNpixels @Hundrec