[ENHANCEMENT] Strumline Background #4166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbnormalPoof
added
type: enhancement
github-actions
bot
added
size: medium
AbnormalPoof
added
type: enhancement
|
Cool! How does this compare to #2949? |
|
This uses a slightly different implementation in the sense that it doesn't rely on changes to the scripts for Blazin' to work properly. (Background is set to 70% here for better visibility) |
|
No clue how this commit managed to get onto the public branch! A version of this commit with an identical changelist (but a different commit ID, maybe it got rebased) was already approved and merged internally, so expect to see it in v0.6. (I guess that means reject the PR but give it the Milestone? a little confusing) Fun bit of trivia, this feature broke with the QT: Rewired mod but I made a fix for that. |
EliteMasterEric
added
status: resolved internally
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Closes #2954
Briefly describe the issue(s) fixed.
I found this commit in a branch named
appdomain-blacklist, this was created after #2942 was merged. This branch was used for PR #3555 but had a very messy commit history.This commit isn't in
developat all, so this PR simply cherry-picks it!Side note: I have literally zero idea how to remove myself from being an author, sorry!
Include any relevant screenshots or videos.