Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick develop branch fix (again, the last one i promise sob) #4171

Merged

Conversation

AbnormalPoof
Copy link
Collaborator

I fucked up the scrollfactor by having the default be [0, 0] instead of [1, 1]. This made the characters move all weird as seen in #3720 (comment)

My bad!!!

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. labels Feb 18, 2025
@AbnormalPoof AbnormalPoof added type: minor bug Involves a minor bug or issue. status: pending triage Awaiting review. and removed pr: haxe PR modifies game code. labels Feb 18, 2025
@github-actions github-actions bot added the size: small A small pull request with 10 or fewer changes. label Feb 18, 2025
@AbnormalPoof AbnormalPoof added the pr: haxe PR modifies game code. label Feb 18, 2025
@AbnormalPoof AbnormalPoof changed the title Quick develop branch fix (again) Quick develop branch fix (again, the last one i promise 😭) Feb 18, 2025
@AbnormalPoof AbnormalPoof changed the title Quick develop branch fix (again, the last one i promise 😭) Quick develop branch fix (again, the last one i promise sob) Feb 18, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Feb 18, 2025

The result is hilarious, thanks for making this happen 😆

@EliteMasterEric EliteMasterEric added this to the 0.6.0 (Pit Stop 2) milestone Feb 18, 2025
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Feb 18, 2025
@EliteMasterEric EliteMasterEric merged commit 5054c58 into FunkinCrew:develop Feb 18, 2025
7 checks passed
@AbnormalPoof AbnormalPoof deleted the scrollfactor-fix-lol branch February 18, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants