Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT]: Miss Sound Preference #4177

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

[ENHANCEMENT]: Miss Sound Preference #4177

wants to merge 16 commits into from

Conversation

JVNpixels
Copy link
Contributor

@JVNpixels JVNpixels commented Feb 19, 2025 •
edited
Loading

Does this PR close any issues? If so, link them below.

No, this does not close any issues.

Briefly describe the issue(s) fixed.

I added the option to turn on/off miss sounds, with the default setting being true.
For some people, the miss sound can get annoying, so you can either turn it on or off.

Include any relevant screenshots or videos.

image
image
https://youtu.be/R4EUZcBPL2g

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. and removed status: pending triage Awaiting review. labels Feb 19, 2025
@JVNpixels JVNpixels marked this pull request as draft February 19, 2025 01:00
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Feb 19, 2025
@JVNpixels
Copy link
Contributor Author

that was quick also yea i screwed something up and im fixing it rn lol

@github-actions github-actions bot added the size: medium A medium pull request with 100 or fewer changes. label Feb 19, 2025
@JVNpixels JVNpixels marked this pull request as ready for review February 19, 2025 01:31
@github-actions github-actions bot removed the size: large A large pull request with more than 100 changes. label Feb 19, 2025
@JVNpixels
Copy link
Contributor Author

This should be ready for review now.

@JackXson-Real
Copy link

This would be pretty handy for people who find the miss sound to be annoying! I would probably use this option myself.

@Starexify
Copy link

I approve 🗿👍

@JVNpixels
Copy link
Contributor Author

I approve 🗿👍

Thanks! You should hit the approve button!

AbnormalPoof
AbnormalPoof suggested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@AbnormalPoof AbnormalPoof left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems fine. But it appears you made some (accidental?) formatting changes. I pointed them out in my review comments. Please undo them!

@JVNpixels
Copy link
Contributor Author

JVNpixels commented Feb 20, 2025 •
edited
Loading

This PR seems fine. But it appears you made some (accidental?) formatting changes. I pointed them out in my review comments. Please undo them!

The changes you stated were in fact accidental, my apologies!

@JVNpixels
Copy link
Contributor Author

These changes should now be fixed!

@AbnormalPoof AbnormalPoof removed their request for review February 21, 2025 00:11
@EliteMasterEric EliteMasterEric self-assigned this Feb 21, 2025
@EliteMasterEric EliteMasterEric added status: reviewing internally Under consideration and testing. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Feb 22, 2025
Hundrec
Hundrec suggested changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change to the preference description and I'll approve!

@JVNpixels
Copy link
Contributor Author

I was thinking of doing that, but I wasn’t sure since some of the option descriptions on the develop branch them old formatting, and some had new formatting.

AbnormalPoof
AbnormalPoof suggested changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still some accidental formatting:

@JVNpixels

This comment was marked as outdated.

Sign in to view
@JVNpixels
Copy link
Contributor Author

Alright, that appears to be all of the formatting changes! My apologies on that, it seems like the branches got mixed up and had weird merge changes. It should be all fixed now.

AbnormalPoof
AbnormalPoof approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Hundrec
Hundrec approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackXson-Real JackXson-Real JackXson-Real approved these changes

@AbnormalPoof AbnormalPoof AbnormalPoof approved these changes

@Hundrec Hundrec Hundrec approved these changes

Assignees

@EliteMasterEric EliteMasterEric

Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: reviewing internally Under consideration and testing. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JVNpixels @JackXson-Real @Starexify @AbnormalPoof @Hundrec @EliteMasterEric