Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart editor - Deselect items after moving #4183

Conversation

Lasercar
Copy link
Contributor

Does this PR close any issues? If so, link them below.

#3761

Briefly describe the issue(s) fixed.

After a selection of notes is moved, it doesn't also deselect them. This fixes that?

Include any relevant screenshots or videos.

@Lasercar Lasercar changed the title Deselect items after moving Chart editor - Deselect items after moving Feb 19, 2025
@github-actions github-actions bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. labels Feb 19, 2025
@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 19, 2025

@Hundrec @amyspark-ng Could you try out PR in a local branch and see if it fixes that selection issue?

Nvm, that won't be necessary.

What the heck, this is one weird issue.

@Lasercar Lasercar marked this pull request as draft February 19, 2025 12:06
@Lasercar Lasercar force-pushed the chart-editor-deselect-items-after-moving branch from f0a104f to e4e651c Compare February 19, 2025 12:27
@Lasercar Lasercar force-pushed the chart-editor-deselect-items-after-moving branch from e4e651c to f63046e Compare February 19, 2025 13:02
@Lasercar Lasercar closed this Feb 19, 2025
@Lasercar Lasercar deleted the chart-editor-deselect-items-after-moving branch February 19, 2025 13:02
@Lasercar Lasercar changed the title Chart editor - Deselect items after moving Chart editor - chart-editor-select-items-properly Feb 19, 2025
@Lasercar Lasercar changed the title Chart editor - chart-editor-select-items-properly Chart editor - Deselect items after moving Feb 19, 2025
@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 19, 2025

Whoops, I didn't know that renaming a branch does this.

Doesn't matter, the change I made still didn't fix the issue.

@AbnormalPoof AbnormalPoof added status: rejected Issue did not pass review or PR cannot be approved. and removed status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants