-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart editor - Improved context menus #4200
base: develop
Are you sure you want to change the base?
Chart editor - Improved context menus #4200
Conversation
5eb53f6
to
529f992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good!
Directly set the item's position and for hold notes, it's length as well Values can be shown and set in milliseconds or steptime
529f992
to
a024202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Also, if anyone has tips on how to make these changes smaller/refactoring it I'd be happy to hear them! |
Yeah, I've already fixed this. |
what is the last commit selection offset |
Input an offset value, and then move the selection by that (basically, a regular move selection by mouse but done by input and button instead). I originally thought against it, but then I reconsidered and thought people might find it handy for offsetting the entire song, for example. The second video in the details dropdown in the description shows off this new functionality. |
Does this PR close any issues? If so, link them below.
Closes #4197
Briefly describe the issue(s) fixed.
There isn't any place to see a note's time and length, which is a down grade from the previous chart editor that had a menu for seeing and editing the time and length of notes and the time of events.
This PR fixes that by adding the option to see and set the time (and length if it's a hold note) of notes and events directly, through the use of the context menu.
Requires this FunkinCrew/funkin.assets#127 assets PR.
Please note that there is one issue where a new hold note doesn't properly update, but it's not an issue with the PR itself.
Update - now includes the ability to offset a selection, either by milliseconds or steps (basically, a regular move selection by mouse but done by input and button instead).
Also pairs really well with this PR: #4231
Include any relevant screenshots or videos.
Videos
2025-02-22.18-25-31.1.mp4
2025-02-26.21-44-40.mp4