Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart editor - Improved context menus #4200

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Lasercar
Copy link
Contributor

@Lasercar Lasercar commented Feb 22, 2025

Does this PR close any issues? If so, link them below.

Closes #4197

Briefly describe the issue(s) fixed.

There isn't any place to see a note's time and length, which is a down grade from the previous chart editor that had a menu for seeing and editing the time and length of notes and the time of events.

This PR fixes that by adding the option to see and set the time (and length if it's a hold note) of notes and events directly, through the use of the context menu.

Requires this FunkinCrew/funkin.assets#127 assets PR.

Please note that there is one issue where a new hold note doesn't properly update, but it's not an issue with the PR itself.

Update - now includes the ability to offset a selection, either by milliseconds or steps (basically, a regular move selection by mouse but done by input and button instead).

Also pairs really well with this PR: #4231

Include any relevant screenshots or videos.

Videos
2025-02-22.18-25-31.1.mp4
2025-02-26.21-44-40.mp4

Screenshot 2025-02-22 230806
Screenshot 2025-02-22 230845

@github-actions github-actions bot added pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. labels Feb 22, 2025
@Lasercar Lasercar changed the base branch from develop to main February 22, 2025 08:37
@Lasercar Lasercar changed the base branch from main to develop February 22, 2025 08:37
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. topic: chart editor Related to the operation of the Chart Editor. labels Feb 22, 2025
@Lasercar Lasercar force-pushed the chart-editor-improved-context-menus branch 2 times, most recently from 5eb53f6 to 529f992 Compare February 22, 2025 13:20
Copy link

@JackXson-Real JackXson-Real left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good!

Directly set the item's position and for hold notes, it's length as well
Values can be shown and set in milliseconds or steptime
@Lasercar Lasercar force-pushed the chart-editor-improved-context-menus branch from 529f992 to a024202 Compare February 22, 2025 14:03
Copy link
Contributor

@JVNpixels JVNpixels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 23, 2025

Also, if anyone has tips on how to make these changes smaller/refactoring it I'd be happy to hear them!

@amyspark-ng
Copy link
Contributor

image
guessing the second box is for length, i would call it length instead of also time

@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 23, 2025

guessing the second box is for length, i would call it length instead of also time

Yeah, I've already fixed this.

@amyspark-ng
Copy link
Contributor

what is the last commit selection offset

@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 27, 2025

what is the last commit selection offset

Input an offset value, and then move the selection by that (basically, a regular move selection by mouse but done by input and button instead). I originally thought against it, but then I reconsidered and thought people might find it handy for offsetting the entire song, for example.

The second video in the details dropdown in the description shows off this new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Hold note context menu has an input for the hold note's length
5 participants