Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP + ENHANCEMENT] rework polymod buildImports #4219

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[CLEANUP + ENHANCEMENT] rework polymod buildImports #4219

wants to merge 2 commits into from

Conversation

cyn0x8
Copy link
Contributor

@cyn0x8 cyn0x8 commented Feb 24, 2025 •
edited
Loading

  • organizes default imports and aliases and blacklists
  • eases restriction on sys package (idk why its a blanket blacklist since it still has some useful classes for modding like sys.Http or sys.thread.Deque)
    • now only blocks possibly malicious classes like sys.io.* and sys.FileSystem
  • added a few more common imports to default imports
    • flixel.FlxG
    • funkin.Conductor
    • funkin.modding.module.ModuleHandler
    • funkin.play.PlayState

Warning

existing prs that change buildImports will conflict

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. labels Feb 24, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. topic: mods Related to the creation or use of mods. labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyn0x8 @AbnormalPoof