Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHART EDITOR] Added tooltip field for data event fields #4220

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

amyspark-ng
Copy link
Contributor

@amyspark-ng amyspark-ng commented Feb 24, 2025

Does this PR close any issues? If so, link them below.

fixes #4218

Briefly describe the issue(s) fixed.

This adds tooltips for event data fields, this way the field of any event toolbox will add extra info on how the event uses that field

Mods that use custom events can also make use of this when creating their SongEventSchema, it would look something like this:

class CustomEvent extends SongEvent {
    public function new() {
        super('customEvent');
    }
    
    public override function getEventSchema(): SongEventSchema {
        return [
            {
                name: "quantity",
                title: "Attack Quantity",
                defaultValue: 1,
                type: "integer",
                step: 1,
                tooltip: "The amount of attacks to do"
            }
        ];
    }
}

Include any relevant screenshots or videos.

You can't look at it properly due to #4126 but they seem to work properly

2025-02-23_22-27-30.mp4

@github-actions github-actions bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels Feb 24, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. topic: chart editor Related to the operation of the Chart Editor. labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants