Main menu not remembering freeplay menu selection fix #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rewrite CHANGELOG.md for v0.5.2 * [docs] Add missing changes and links to Changelog (FunkinCrew#3655) * changelog sweep * Resolve a few conflicts * Resolve more conflicts * DadBattle * Re-add @ianharrigan * Add links to 0.5.0 * Add links and contributors to 0.4.1 and 0.4.0 * Add links to 0.3.3 and finishing touches * Add and polish 0.5.3 changes * Make spacing consistent * Make label actions more convenient (FunkinCrew#3771) * fixed a plethora of dead links (FunkinCrew#3831) * Add `status: planned` label to label actions (FunkinCrew#3910) * Make label actions more convenient * chore: Add status: planned to label actions * Bump the Stage data version to indicate that new values were added. * Updated Save data version to indicate new values. * Only display the Stage Editor in builds that enable it, and enable it by default (this re-enables the Stage Editor keybind). * Enable log messages on all builds by default after we got too many complaints. * Remove unused custom type resolver. * Update save data format and error handling. * Fix a typo. * proj hxp version bump * changelog yoink * Remove duplicate issue detector. (FunkinCrew#3944) --------- Co-authored-by: Hundrec <[email protected]> Co-authored-by: Abnormal <[email protected]> Co-authored-by: Cameron Taylor <[email protected]>
…3721) * add events for focus gain/lost * add callbacks * move the events to a new interface * Ok NOW it works * the event can now longer be canceled
* updated preference menu * update comment
* add album title offsets * cleanup * cleanup * fix inconsistency
* Custom render distance strumline * Custom note positions * Custom vertices for holds * Song Retry Event Song retry event for pausesubstate.hx Song retry event for playstate.hx Song retry event for stage.hx Song retry event for bopper.hx Song retry event for song.hx Scripted class event Module event * this should be cast * Show notesplash toggle * Formatting and EOF
Co-authored-by: Kolo <[email protected]>
a lot of squashed stuff
Move changes from `main` to `develop`
Merge from main into develop
Co-authored-by: Hundrec <[email protected]> Co-authored-by: Abnormal <[email protected]>
Includes a line about warnings and deprecated functions, as well as a line about the hxcpp prompt.
This reverts commit 3267c61.
github-actions
bot
added
size: large
|
huh? How'd that happen? Why didn't it fix itself after changing the branch? |
AbnormalPoof
added
status: rejected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Briefly describe the issue(s) fixed.
Title. It's literally because the freeplay state is opened as a substate and therefore doesn't call startExitState, which updates the rememberedSelectedIndex.
This PR simply adds that line into the freeplay menu item callback function.
Include any relevant screenshots or videos.