Remove jbrowse-web start screen #4735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
rm_start_screen
branch
3 times, most recently
from
3f80419 to
8d1f913
Compare
cmdcolin
force-pushed
the
rm_start_screen
branch
from
8d1f913 to
3b8214c
Compare
|
an alternative to this PR could be a fully customizable start screen, or, links to launch a linear genome view for all of the different assemblies (sort of similar to to the dataset list in jbrowse 1), or just something that feels a little more customized for the users instance. the currently start screen is very 'basic' and unthemed so doesn't give the sense that it belongs to a particular portal |
|
but...again, could also just remove start screen by default entirely, as this PR proposes, and see what happens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible way to address #4734
It just always sets the defaultSession on the jbrowse model, and doesn't let you set it to undefined (which is what "Return to start screen" did)