Free resources associated with layout and cached features when browsing to a new region in worker #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Possible fix towards #4844 |
cmdcolin
force-pushed
the
free_resources_in_worker
branch
3 times, most recently
from
e6a1d0d to
c9e05a3
Compare
|
i believe a tool like memlab should be employed to properly search for memory leaks https://github.com/facebook/memlab |
|
I can confirm that this should fix a major memory leak
there is a failing CI test but can be reviewed |
cmdcolin
force-pushed
the
free_resources_in_worker
branch
from
c9e05a3 to
480e5e8
Compare
cmdcolin
force-pushed
the
free_resources_in_worker
branch
from
9d3fa99 to
ab8d5f4
Compare
cmdcolin
force-pushed
the
free_resources_in_worker
branch
from
ab8d5f4 to
49d7311
Compare
cmdcolin
force-pushed
the
free_resources_in_worker
branch
from
5967db3 to
37bb5ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code fails to free resources associated with the layout, which includes a pointer to the features, when you browse to a new region
This is because it tries to clear the layout in a freeResourcesInClient function, but it needs to run on the worker
This changes it to run the code on the worker