fba-button, as a button
#1763
Open
fba-button, as a button
#1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the fba-button link that hovers in the bottom right-hand corner of pages,
and updates from a
<a>to a<button>, to improve accessibility and to be more semantically accurate.also adds an
aria-labelwith the same text as the button, for improved accessibility (reported by Amy Cole of USWDS)A feature flag on the Form object called
legacy_link_feature_flagexists, in case there are any issues with this update (eg: custom CSS or js that targets thata)