Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Recipe for Solar Factory #1120

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Conversation

purebluez
Copy link

@purebluez purebluez commented Dec 24, 2024

Related PR: GTNewHorizons/GT5-Unofficial#3703

Of course, do not merge this unless the related PR is merged.
Also, please close if the related PR is closed.

The Recipe, which is also shown in the related PR.
image

The recipes Solar Factory do have been moved here. See the bottom of related PR description for what they look like.

Closes https://github.com/GTNewHorizons/areas-of-interest/issues/6

@EnderProyects
Copy link
Contributor

You could add a luv solar panel to the recipe so in order to craft the controller it needs some resources spended in the normal way ( this also can make new players see that this recipes are much better) 😜

@Dream-Master Dream-Master requested a review from a team December 26, 2024 21:39
@purebluez
Copy link
Author

Forgot to do this before
Converting to draft since related pr is also a draft

@purebluez purebluez marked this pull request as draft December 28, 2024 16:30
@purebluez purebluez marked this pull request as ready for review January 23, 2025 02:48
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 25, 2025
@Dream-Master
Copy link
Member

image
can you add this tem as well. ik we remove super solar mod some day but we well readd items to core mod

@Dream-Master
Copy link
Member

zpm missing asoc wafers
image

@Dream-Master
Copy link
Member

I see recursive recipes use always tier 1 and advanced version always t3. Can you change this so Lv-hv use ev-luv t2 and zpm to uv t3. What about t4 four? i see it in 3d nei

@purebluez
Copy link
Author

What about t4 four? i see it in 3d nei

4th tier in the NEI structure viewer is just 3rd multi tier but with t4 precise casing. I would disable it showing the "4th tier" if I knew how, since there is no tier 4 in code.
The rest of your changes suggested I will implement. Thank you for the feedback!

Copy link
Member

@Dream-Master Dream-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@purebluez why the buff? yea ik the recipes a bit more expensive but i not support this buff

@purebluez
Copy link
Author

why the buff? yea ik the recipes a bit more expensive but i not support this buff

GTNewHorizons/GT-New-Horizons-Modpack#18925 complained about the prices and after some thought i decided the recursive recipes are best not being buffed, so they are now 1:1 with dire table

Im certain the wafer mechanic would not shift balance much for powergen, as you need to be at least a tier higher than what the recipe calls for. For example, if HV solar calls for Phosphorus wafers, to get an output multiplier you would need a Naquadah wafer which is tiered to LuV. Not saying the multiplier is useless either, it will let you save alot of material if you make solars for use in crafting recipes like Dyson parts.

For the skipping recipes, those are intended to be made 2 tiers higher than the normal recipe. You can see on the recipe table that MV solar for example uses some ingredients from the EV solar. The point of the skipping recipes is solely convenience, and id say by the time you can make an EV solar there's no point to running the skipping MV recipe for powergen, where the balance really matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants