Skip to content

Commit

Permalink
Copy @hide util files into framework-telephony.
Browse files Browse the repository at this point in the history
Also add jarjar rules for them.

Bug: 140908357
Test: build
Change-Id: I4411be058a002a4339ea563f444de9f4c0b67f23
  • Loading branch information
Malcolm Chen committed Jan 16, 2020
1 parent 546ce5e commit 58b59a5
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 6 deletions.
25 changes: 21 additions & 4 deletions Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -1126,9 +1126,10 @@ genrule {
}

// Avoid including Parcelable classes as we don't want to have two copies of
// Parcelable cross the process.
// Parcelable cross the libraries. This is used by telephony-common (frameworks/opt/telephony)
// and TeleService app (packages/services/Telephony).
filegroup {
name: "framework-telephony-stack-shared-srcs",
name: "framework-telephony-common-shared-srcs",
srcs: [
"core/java/android/os/BasicShellCommandHandler.java",
"core/java/android/os/RegistrantList.java",
Expand All @@ -1150,6 +1151,21 @@ filegroup {
],
}

// Avoid including Parcelable classes as we don't want to have two copies of
// Parcelable cross the process. This is used by framework-telephony (frameworks/base/telephony).
filegroup {
name: "framework-telephony-shared-srcs",
srcs: [
"core/java/android/util/RecurrenceRule.java",
"core/java/com/android/internal/os/SomeArgs.java",
"core/java/com/android/internal/util/BitwiseInputStream.java",
"core/java/com/android/internal/util/BitwiseOutputStream.java",
"core/java/com/android/internal/util/HexDump.java",
"core/java/com/android/internal/util/IndentingPrintWriter.java",
"core/java/com/android/internal/util/Preconditions.java",
],
}

// Avoid including Parcelable classes as we don't want to have two copies of
// Parcelable cross the process.
filegroup {
Expand Down Expand Up @@ -1272,6 +1288,7 @@ java_library {
name: "framework-telephony",
srcs: [
":framework-telephony-sources",
":framework-telephony-shared-srcs",
],
// TODO: change to framework-system-stub to build against system APIs.
libs: [
Expand All @@ -1290,7 +1307,7 @@ java_library {
"frameworks/native/aidl/gui",
]
},
jarjar_rules: ":telephony-framework-jarjar-rules",
jarjar_rules: ":framework-telephony-jarjar-rules",
dxflags: [
"--core-library",
"--multi-dex",
Expand All @@ -1309,6 +1326,6 @@ filegroup {
}

filegroup {
name: "telephony-framework-jarjar-rules",
name: "framework-telephony-jarjar-rules",
srcs: ["telephony/framework-telephony-jarjar-rules.txt"],
}
9 changes: 7 additions & 2 deletions telephony/framework-telephony-jarjar-rules.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
rule android.telephony.Annotation* android.telephony.framework.Annotation@1
rule android.util.RecurrenceRule* android.telephony.RecurrenceRule@1
rule com.android.i18n.phonenumbers.** com.android.telephony.framework.phonenumbers.@1
#TODO: add jarjar rules for statically linked util classes

rule com.android.internal.os.SomeArgs* android.telephony.SomeArgs@1
rule com.android.internal.util.BitwiseInputStream* android.telephony.BitwiseInputStream@1
rule com.android.internal.util.BitwiseOutputStream* android.telephony.BitwiseOutputStream@1
rule com.android.internal.util.Preconditions* android.telephony.Preconditions@1
rule com.android.internal.util.IndentingPrintWriter* android.telephony.IndentingPrintWriter@1
rule com.android.internal.util.HexDump* android.telephony.HexDump@1

0 comments on commit 58b59a5

Please sign in to comment.