Merge pull request #42 from slider/fix_invalid_crontab_breaking_hajobs

Fix invalid cron expressions breaking haJobs when job is manually triggered

.gitignore

@@ -1,2 +1,3 @@
 target/
 .idea/
+*.iml

ha-jobs-core/src/main/scala/de/kaufhof/hajobs/JobManager.scala

@@ -88,27 +88,32 @@ class JobManager(managedJobs: => Jobs,
       jobToSchedule.cronExpression match {
         case Some(cronExpression) =>
           logger.debug("scheduling job for {}", jobType)
-          val job = JobBuilder
-            .newJob(classOf[TriggerPuller])
-            .usingJobData(TPData(jobType, this).asDataMap)
-            .build()
+          if(org.quartz.CronExpression.isValidExpression(cronExpression)) {
+            val job = JobBuilder
+              .newJob(classOf[TriggerPuller])
+              .usingJobData(TPData(jobType, this).asDataMap)
+              .build()
 
-          val jobName = jobType.name
+            val jobName = jobType.name
 
-          val trigger = TriggerBuilder
-            .newTrigger
-            .withIdentity(s"$jobName-trigger")
-            .withSchedule(CronScheduleBuilder
-            // this will throw an exception if the expression is incorrect
-            .cronSchedule(cronExpression)
-              .inTimeZone(schedulesTimeZone)
-            ).build()
+            val trigger = TriggerBuilder
+              .newTrigger
+              .withIdentity(s"$jobName-trigger")
+              .withSchedule(CronScheduleBuilder
+              // this will throw an exception if the expression is incorrect
+              .cronSchedule(cronExpression)
+                .inTimeZone(schedulesTimeZone)
+              ).build()
 
-          scheduler.scheduleJob(job, trigger)
+            scheduler.scheduleJob(job, trigger)
 
-          logger.info("Job '{}' has cron expression '{}', first execution at {}", jobType, trigger.getCronExpression, trigger.getNextFireTime)
+            logger.info("Job '{}' has cron expression '{}', first execution at {}", jobType, trigger.getCronExpression, trigger.getNextFireTime)
 
-          runJobNowIfPreviousRunWasSkipped(cronExpression, jobType).map(_ => ())
+            runJobNowIfPreviousRunWasSkipped(cronExpression, jobType).map(_ => ())
+          } else {
+            logger.info("Invalid cronExpression defined for job {}", jobType)
+            Future.successful(())
+          }
         case None =>
           logger.info("No cronExpression defined for job {}", jobType)
           Future.successful(())