fix(ts3server): Monitor command fails, if query_ip is set to a loopback IP #3730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix monitoring failing and restarting the teamspeak server, if the query interface is bound to a loopback IP.
I didn't want to remove the logic for filtering loopback IPs, so I just added fetching the
query_ip
from thets3server.ini
and using that one asqueryips
incheck_ip
which then will be used incommand_monitor
.I also added the other configurable teamspeak IPs as variables, even if they currently have no use.
Background
I don't want remote users to connect to the teamspeak query interface, so I bound it to
127.0.0.1
.With the 21.5.0 Release
ts3
got added toinfo_game
and the monitor command is now checking the query port, butcheck_ip
is filtering127.0.0
-IPs, so the monitor command was failing for me every time.I'm not 100% certain that this is the cause but it started after the
update-lgsm
cron had run, and this are the only changes where I could see a effect on ts3server.Type of change
Checklist
PR will not be merged until all steps are complete.
develop
branch as its base.Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!