Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format GDScript files using Razoric's formatter + manual review #308

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

aaronfranke
Copy link
Contributor

This PR runs Razoric's code formatter on every GDScript file in this repo, except for the ones in Gut since that's third-party code. Then I manually looked over all of the changes and only picked out the places where formatting is improved, this is necessary since the formatter has many bugs. This brings Godot Firebase closer to the GDScript style guide. A lot of this is replacing space indentation with tabs, and removing spaces before colons.

I have checked that Godot is still able to read these files, but I have not ran the tests. Please test before merging.

@WolfgangSenff
Copy link
Collaborator

Hm. I'm not sure if I like replacing spaces with tabs - certain editors do not handle tabs correctly. It's always been my rule to use spaces in library code. This is where I would probably ignore the formatter. I'm fine with the removing spaces before colons though.

@aaronfranke
Copy link
Contributor Author

Tabs work well in both Godot and VS Code, which are mostly what Godot developers will be using. Regardless, this is easy to change later, so I don't want it to get in the way of the rest of these changes. I updated the PR to remove the indentation changes, so now it's just all of the other formatting changes.

@WolfgangSenff WolfgangSenff merged commit 4df1a40 into GodotNuts:main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants