fix tests

GoogleChrome · Jun 6, 2024 · 43ed9e5 · 43ed9e5
1 parent dd01b17
commit 43ed9e5
Show file tree

Hide file tree

Showing 6 changed files with 43 additions and 7 deletions.
diff --git a/core/test/audits/byte-efficiency/offscreen-images-test.js b/core/test/audits/byte-efficiency/offscreen-images-test.js
@@ -458,7 +458,11 @@ describe('OffscreenImages audit', () => {
           src: recordB.url,
         }),
       ],
-      traces: {defaultPass: createTestTrace({topLevelTasks, networkRecords})},
+      traces: {defaultPass: createTestTrace({
+        largestContentfulPaint: 15,
+        topLevelTasks,
+        networkRecords,
+      })},
       devtoolsLogs: {defaultPass: devtoolsLog},
       URL: {
         requestedUrl: recordA.url,
@@ -523,7 +527,11 @@ describe('OffscreenImages audit', () => {
           src: recordB.url,
         }),
       ],
-      traces: {defaultPass: createTestTrace({topLevelTasks, networkRecords})},
+      traces: {defaultPass: createTestTrace({
+        largestContentfulPaint: 15,
+        topLevelTasks,
+        networkRecords,
+      })},
       devtoolsLogs: {defaultPass: devtoolsLog},
       URL: {
         requestedUrl: recordA.url,

diff --git a/core/test/audits/dobetterweb/dom-size-test.js b/core/test/audits/dobetterweb/dom-size-test.js
@@ -20,6 +20,7 @@ describe('DOMSize audit', () => {
     const mainDocumentUrl = 'https://example.com/';
     const networkRecords = [{url: mainDocumentUrl, priority: 'High'}];
     const trace = createTestTrace({
+      largestContentfulPaint: 15,
       topLevelTasks: [
         {ts: 1000, duration: 1000, children: [
           {ts: 1100, duration: 200, eventName: 'ScheduleStyleRecalculation'},

diff --git a/core/test/audits/long-tasks-test.js b/core/test/audits/long-tasks-test.js
@@ -52,6 +52,7 @@ function generateTraceWithLongTasks(args) {
     traceTasks.push(task);
   }
   return createTestTrace({
+    largestContentfulPaint: BASE_TS + 15,
     topLevelTasks: traceTasks,
     timeOrigin: BASE_TS,
     traceEnd: BASE_TS + 20_000,

diff --git a/core/test/audits/redirects-test.js b/core/test/audits/redirects-test.js
@@ -129,7 +129,12 @@ describe('Performance: Redirects audit', () => {
     const devtoolsLog = networkRecordsToDevtoolsLog(networkRecords);
     const frameUrl = networkRecords[0].url;
 
-    const trace = createTestTrace({frameUrl, traceEnd: 5000, networkRecords});
+    const trace = createTestTrace({
+      frameUrl,
+      largestContentfulPaint: 15,
+      traceEnd: 5000,
+      networkRecords,
+    });
     const navStart = trace.traceEvents.find(e => e.name === 'navigationStart');
     navStart.args.data.navigationId = '1';
 

diff --git a/core/test/audits/third-party-facades-test.js b/core/test/audits/third-party-facades-test.js
@@ -44,7 +44,12 @@ describe('Third party facades audit', () => {
       devtoolsLogs: {
         defaultPass: networkRecordsToDevtoolsLog(networkRecords),
       },
-      traces: {defaultPass: createTestTrace({timeOrigin: 0, traceEnd: 2000, networkRecords})},
+      traces: {defaultPass: createTestTrace({
+        timeOrigin: 0,
+        largestContentfulPaint: 15,
+        traceEnd: 2000,
+        networkRecords,
+      })},
       URL: {
         requestedUrl: 'https://example.com',
         mainDocumentUrl: 'https://example.com',
@@ -99,7 +104,12 @@ describe('Third party facades audit', () => {
       devtoolsLogs: {
         defaultPass: networkRecordsToDevtoolsLog(networkRecords),
       },
-      traces: {defaultPass: createTestTrace({timeOrigin: 0, traceEnd: 2000, networkRecords})},
+      traces: {defaultPass: createTestTrace({
+        timeOrigin: 0,
+        largestContentfulPaint: 15,
+        traceEnd: 2000,
+        networkRecords,
+      })},
       URL: {
         requestedUrl: 'https://example.com',
         mainDocumentUrl: 'https://example.com',
@@ -175,7 +185,12 @@ describe('Third party facades audit', () => {
       devtoolsLogs: {
         defaultPass: networkRecordsToDevtoolsLog(networkRecords),
       },
-      traces: {defaultPass: createTestTrace({timeOrigin: 0, traceEnd: 2000, networkRecords})},
+      traces: {defaultPass: createTestTrace({
+        timeOrigin: 0,
+        largestContentfulPaint: 15,
+        traceEnd: 2000,
+        networkRecords,
+      })},
       URL: {
         requestedUrl: 'https://example.com',
         mainDocumentUrl: 'https://example.com',
@@ -226,7 +241,12 @@ describe('Third party facades audit', () => {
       devtoolsLogs: {
         defaultPass: networkRecordsToDevtoolsLog(networkRecords),
       },
-      traces: {defaultPass: createTestTrace({timeOrigin: 0, traceEnd: 2000, networkRecords})},
+      traces: {defaultPass: createTestTrace({
+        timeOrigin: 0,
+        largestContentfulPaint: 15,
+        traceEnd: 2000,
+        networkRecords,
+      })},
       URL: {
         requestedUrl: 'https://intercomcdn.com',
         mainDocumentUrl: 'https://intercomcdn.com',

diff --git a/core/test/computed/tbt-impact-tasks-test.js b/core/test/computed/tbt-impact-tasks-test.js
@@ -34,6 +34,7 @@ describe('TBTImpactTasks', () => {
     beforeEach(() => {
       metricComputationData = {
         trace: createTestTrace({
+          largestContentfulPaint: 15,
           traceEnd: 10_000,
           frameUrl: mainDocumentUrl,
           topLevelTasks: [