Skip to content

Commit

Permalink
fix initiator in createTestTrace
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark committed Jun 4, 2024
1 parent 2a12f9a commit ed0ef5c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions core/test/audits/largest-contentful-paint-element-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,6 @@ function mockNetworkRecords() {
}

describe('Performance: largest-contentful-paint-element audit', () => {
// TODO(15841): investigate failures
if (process.env.INTERNAL_LANTERN_USE_TRACE !== undefined) {
return;
}

it('correctly surfaces the LCP element', async () => {
const networkRecords = mockNetworkRecords();
const artifacts = {
Expand Down
2 changes: 1 addition & 1 deletion core/test/create-test-trace.js
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@ function createTestTrace(options) {
data: {
requestId,
frame: record.frameId,
initiator: record.initiator ?? {type: 'other'},
},
},
});
Expand All @@ -307,6 +306,7 @@ function createTestTrace(options) {
data: {
requestId,
frame: record.frameId,
initiator: record.initiator ?? {type: 'other'},
priority: record.priority,
requestMethod: record.requestMethod,
resourceType: record.resourceType ?? 'Document',
Expand Down

0 comments on commit ed0ef5c

Please sign in to comment.