core: add hidden audits for each insight #16312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Jan 30, 2025
connorjclark
changed the title
connorjclark
commented
Feb 4, 2025
| @@ -44,7 +44,7 @@ function buildStandaloneReport() { | |||
| outfile: 'dist/report/standalone.js', | |||
| format: 'iife', | |||
| bundle: true, | |||
| minify: true, | |||
There was a problem hiding this comment.
drive by. this is very useful. surprised we didn't already do this.
connorjclark
commented
Feb 4, 2025
| const navigationId = traceEngineResult.data.Meta.mainFrameNavigations[0].args.data?.navigationId; | ||
| if (!navigationId) { | ||
| throw new Error(`Lantern metrics could not be calculated due to missing navigation id`); | ||
| } |
There was a problem hiding this comment.
shifts in types with trace engine...
adamraine
approved these changes
Feb 5, 2025
| */ | ||
| static async audit(artifacts, context) { | ||
| return adaptInsightToAuditProduct(artifacts, context, 'DOMSize', (insight) => { | ||
| if (!insight.maxDOMStats?.args.data.maxChildren || !insight.maxDOMStats?.args.data.maxDepth) { |
There was a problem hiding this comment.
Technically we will still have a valid totalElements value even if these are missing. In practice though, this will only happen if the document element is removed so it's an edge case that really doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adaptInsightToAuditProducthelper, which is given the insight model and the caller returns aLH.Audit.Productyarn generate-insight-auditsscript, to quickly make and configure new audits (just run when new insights exists, no flags). Calling in CI so we don't forget to add a new insight when upgrading trace enginedom-size-insight,viewport-insight, andrender-blocking-insighthave been implemented. The other 11 are blank implementationstrace-engine, which grabs all the node ids referenced in insights and collects their node information