Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: implement more insight audits, handle localization #16326

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

connorjclark
Copy link
Collaborator

ref #16323

  • implement image-delivery-insight
  • implement interaction-to-next-paint-insight
  • implement lcp-phases-insight
  • implement third-parties-insight
  • localize i18n strings - the i18nString in trace_engine package does nothing but pass along its arguments to us to format
  • handle insight errors

@connorjclark connorjclark requested a review from a team as a code owner February 8, 2025 01:14
@connorjclark connorjclark requested review from adamraine and removed request for a team February 8, 2025 01:14
core/audits/insights/lcp-phases-insight.js Outdated Show resolved Hide resolved
core/computed/trace-engine-result.js Outdated Show resolved Hide resolved
@connorjclark connorjclark merged commit 599308b into main Feb 10, 2025
27 checks passed
@connorjclark connorjclark deleted the more-insights branch February 10, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants