-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update to Go 1.23 #1518
chore: Update to Go 1.23 #1518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:
This pull request updates the project to use Go 1.23.
Summary of Changes:
- The
Makefile
has been updated to use thegoogle-go.pkg.dev/golang:1.23.4
image for building the project. - The
go.mod
file in the root directory has been updated to specifygo 1.23
. - The
go.mod
file in thetest/docker/presync-webhook-server
directory has also been updated to specifygo 1.23
.
Intent:
The intent is to upgrade the project's Go version to leverage the latest features, bug fixes, and performance improvements in Go 1.23. This is a standard maintenance task to keep the project current and secure.
Here's a little haiku to lighten the mood:
Go version ascends,
New features, bugs now fixed,
Code shines brighter.
Let me know if you have any questions. Thanks!
-Gemini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request updates the Go version used in the project to 1.23.4. Updating dependencies is good practice. The changes look correct, modifying the Go version in Makefile
, go.mod
, and test/docker/presync-webhook-server/go.mod
. However, consistency in the go.mod
files is recommended.
Ensure thorough testing after this update to verify compatibility and address potential issues introduced by the new Go version. Document the testing performed in the pull request description or commit message.
If applicable, update the project's README to reflect the supported Go version.
The patch version isn't important as a package requirement. It's only required in the makefile because it's used to specify the container base image, which doesn't publish a mutable |
Not sure why
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdowell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
90d185f
into
GoogleContainerTools:main
No description provided.