Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to Go 1.23 #1518

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

karlkfi
Copy link
Contributor

@karlkfi karlkfi commented Dec 19, 2024

No description provided.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This pull request updates the project to use Go 1.23.

Summary of Changes:

  • The Makefile has been updated to use the google-go.pkg.dev/golang:1.23.4 image for building the project.
  • The go.mod file in the root directory has been updated to specify go 1.23.
  • The go.mod file in the test/docker/presync-webhook-server directory has also been updated to specify go 1.23.

Intent:

The intent is to upgrade the project's Go version to leverage the latest features, bug fixes, and performance improvements in Go 1.23. This is a standard maintenance task to keep the project current and secure.

Here's a little haiku to lighten the mood:

Go version ascends,
New features, bugs now fixed,
Code shines brighter.

Let me know if you have any questions. Thanks!

-Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the Go version used in the project to 1.23.4. Updating dependencies is good practice. The changes look correct, modifying the Go version in Makefile, go.mod, and test/docker/presync-webhook-server/go.mod. However, consistency in the go.mod files is recommended.

Ensure thorough testing after this update to verify compatibility and address potential issues introduced by the new Go version. Document the testing performed in the pull request description or commit message.

If applicable, update the project's README to reflect the supported Go version.

go.mod Show resolved Hide resolved
test/docker/presync-webhook-server/go.mod Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@karlkfi
Copy link
Contributor Author

karlkfi commented Dec 19, 2024

The patch version isn't important as a package requirement. It's only required in the makefile because it's used to specify the container base image, which doesn't publish a mutable 1.23 tag, for security reasons.

go.mod Show resolved Hide resolved
@karlkfi
Copy link
Contributor Author

karlkfi commented Dec 20, 2024

Not sure why TestSurfaceFightError is failing repeatedly...

https://oss.gprow.dev/view/gs/oss-prow-build-kpt-config-sync/pr-logs/pull/GoogleContainerTools_kpt-config-sync/1518/kpt-config-sync-presubmit-e2e-multi-repo-test-group1/1869896829970157568

    remediator_test.go:56: 2024-12-20 00:15:53.80075102 +0000 UTC The RootSync reports a fight error
    remediator_test.go:57: 2024-12-20 00:21:53.93321748 +0000 UTC failed after 6m0s to wait for RootSync root-sync rendering error code 2005
    remediator_test.go:57: 2024-12-20 00:21:53.93329945 +0000 UTC ERROR: no errors present

Copy link
Contributor

@sdowell sdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sdowell
Copy link
Contributor

sdowell commented Jan 9, 2025

/retest

Copy link
Contributor

@sdowell sdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 14, 2025
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 90d185f into GoogleContainerTools:main Jan 14, 2025
6 checks passed
@karlkfi karlkfi deleted the karl-go-123 branch January 14, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants